Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
@chadmeyer noticed that
GetOnDevice
on an emptyDataBox
causes an assertion error related to array sizes. I think this was indicating an edge case inGetOnDevice
: the edge case being being thatGetOnDevice
was attempting to copy memory to device even for unallocatedDataBox
es containing no memory.This PR simply adds a little default code making
GetOnDevice
a no-op for emptyDataBox
es.PR Checklist